tests: basic-[debugger-]stepping.rs: Disable SingleUseConsts MIR pass temporarily #147426
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make more of the test pass. It should not be necessary to disable this pass, but by doing it we can avoid further regressions while we figure out how to solve this use case properly. The last two `FIXME(33013)` didn't go away from this change, only the first six. But that can be investigated separately.
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Enselic
force-pushed
the
better-stepping
branch
from
b0564e3 to
5b47948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make more of the test pass. It should not be necessary to disable this pass, but by doing it we can avoid further regressions while we figure out how to solve this use case properly.
We know this use case is sensitive to regressions because it already happened at least once. See #33013 (comment).
CC #130896
The last two
FIXME(#33013)didn't go away from this change, only the first six. But that can be investigated separately.